You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What information was incorrect, unhelpful, or incomplete?
The two sliders to set the envelope of the "Sweep" sound are not working as expected.
What did you expect to see?
There are actually 2 issues:
For both inputs, the values are not updated properly. The input should update the value progressively with a 0.1 step, but it only updates to 0 or 1. The problem comes from that the value is cast into an int in the event listener callback.
The way the release input works is not correct. When the slider is set to left, the release should be 0, whereas when it's set to the right, we should be able to hear the release.
Your can try for yourself here:
If you set the values like this you hear a sound that is plucked:
When you set it like this you hear a longer release:
It should be the other way around
The problem comes from the implementation of the envelope:
sweepEnv.gain.linearRampToValueAtTime(0,time+attackTime-releaseTime// here it shouldn't be a "-" operator);
It looks like this is your first issue. Welcome! 👋
One of the project maintainers will be with you as soon as possible. We
appreciate your patience. To safeguard the health of the project, please
take a moment to read our code of conduct.
Thanks for reporting this (along with the other one). Would you like to open a PR to improve it?
bsmth
added
accepting PR
Feel free to address this with a pull request
and removed
needs triage
Triage needed by staff and/or partners. Automatically applied when an issue is opened.
labels
Jan 25, 2024
What information was incorrect, unhelpful, or incomplete?
The two sliders to set the envelope of the "Sweep" sound are not working as expected.
What did you expect to see?
There are actually 2 issues:
Since their value are between 0 and 1 with a step of 0.1, the usage of "parseInt" is inadecuate.
Your can try for yourself here:
If you set the values like this you hear a sound that is plucked:
When you set it like this you hear a longer release:
It should be the other way around
The problem comes from the implementation of the envelope:
I'm currently going through the Web API guide where this step sequencer is used: https://developer.mozilla.org/en-US/docs/Web/API/Web_Audio_API/Advanced_techniques
Since I identified the what causes the issue in the code I'd be happy to work on a fix + updating the doc.
Do you have any supporting links, references, or citations?
No response
Do you have anything more you want to share?
No response
The text was updated successfully, but these errors were encountered: