Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ELWIC] Infinity Complex - Truncated Strings #591

Open
mseelye opened this issue Oct 1, 2023 · 1 comment
Open

[ELWIC] Infinity Complex - Truncated Strings #591

mseelye opened this issue Oct 1, 2023 · 1 comment
Labels
bug Something isn't working module Defect/Issue related to a specific Module

Comments

@mseelye
Copy link

mseelye commented Oct 1, 2023

Module Information

  • Identifier [ELWIC]
  • Module Name [Infinity Complex]
  • Version [e.g. 6.04 (ELWIC_MBBSEmu)]

Describe the bug
Some of the strings from the DLL, and from the ELWIC.MSG file are getting truncated in game at the first "space" character.

To Reproduce
Steps to reproduce the behavior:

  1. Start Infinity Complex
  2. Wait for 'The Spanish Inquisition' to come by
  3. He/They'll drop an M1 and say, "Take", instead of "Take this, you'll need it." (See ELWIC.DLL DASM)

OR

  1. Look for a gathering of commies, when they are all singing.
  2. They'll yell stuff like "Daylight", instead of "Daylight come and me wanna go home!" (See ELWIC.MSG line 2313, "CMSNG4 {yell Daylight come and me wanna go home!} T")

OR

  1. Wander around and find a commie, (Khan, Doctor Doom, Evil Ted, etc.) and the random things they yell will only be 1 word. Like: "How", instead of "How much is that %s in the window?" (See ELWIC.MSG line 102, ZOMBCRY3 {yell How much is that %s in the window?} T )

Expected behavior
The strings from the DLL and MSG file should be expressed completely in the game instead of truncated.

Screenshots
image

Software Information:

  • OS: [Windows 10]
  • Telnet Client [Putty]
@mseelye
Copy link
Author

mseelye commented Oct 2, 2023

Update:
I tried updating some of the affected strings in the ELWIC.MSG file by changing spaces between words (after the initial command, i.e. 'yell') with hyphens, and these display fine in the game without truncation. So, I'm guessing it has something to do with the space characters.

One thing of note:

If a commie's name is like, "Surlaw The Unfeasible" with spaces, and the commie chooses to yell the string:
ZOMCRY11 {yell Call-me-%s...everybody-does.} T

In the game when "Surlaw The Unfeasible" yells it we get:
Surlaw The Unfeasible yells: "Call-me-Surlaw"
Where it cuts off the string at the first space (first after the space after the command 'yell', anyway).

@enusbaum enusbaum added bug Something isn't working module Defect/Issue related to a specific Module labels Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module Defect/Issue related to a specific Module
Projects
None yet
Development

No branches or pull requests

2 participants