Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on reactive extensions #9

Open
wldevries opened this issue Jan 16, 2017 · 7 comments
Open

Remove dependency on reactive extensions #9

wldevries opened this issue Jan 16, 2017 · 7 comments

Comments

@wldevries
Copy link
Contributor

For us it is rather problematic that this package depends on reactive extensions 3.0. We use ReactiveUI which depends on the older package/version. To be able to use WPFTabTip we need to include its source in our project which is rather unfortunate.

@maximcus
Copy link
Owner

I am not entirely sure what are you proposing. You want to remove reference to reactive extensions and rewrite code that relies on Rx?

@wldevries
Copy link
Contributor Author

Yes, I'm currently investigating how easily this can be done.

@maximcus
Copy link
Owner

You can rewrite code that relies on Rx with threads and locks, but I would seriously consider this only if your issue will gain some traction (If many people will have the same problem). Otherwise I would prefer to stick with Rx, even if that is a deal breaker for you, sorry.

@roy-t
Copy link

roy-t commented Aug 21, 2017

I'm affected by the same issue.

What happened is this:

Microsoft published the reactive extensions library under the package id Rx-Main (and dependencies). A lot of other packages depend on these packages. One example is ReactiveUI.

Recently Microsoft decided to rename the package to System.Reactive (and dependencies). The DLL files included in this package are the same as in the Rx-Main package. But a slightly newer version.

This broke the upgrade path. I cannot update the Rx-Main package so it works with WpfTabTip and I cannot install the System.Reactive package because it conflicts with the Rx-Main packages. (The DLL files in the package still have the same name, so I get duplicate references and files get overwritten during build).

What I did for now was to include the entire WpfTabTip source code in my application and change it to reference the Rx-Main package instead of the System.Reactive package. Works perfectly. 😄

@roy-t
Copy link

roy-t commented Aug 23, 2017

I've logged an issue with System.Reactive, unfortunately they can't fix it on their end: dotnet/reactive#416

@maximcus
Copy link
Owner

@roy-t, what about ReactiveUI developers, is there any hope that they will move to a newer version of Rx anytime soon? Or do you have problems not connected to ReactiveUI?

@roy-t
Copy link

roy-t commented Aug 23, 2017

I believe a new version of ReactiveUI is in the works. But I don't think there is a release date has been set. I do know they plan on using the new nuget package for System.Reactive. So I guess this problem will solve itself in the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants