Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Keychain-backed settings #536

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

[RFC] Keychain-backed settings #536

wants to merge 9 commits into from

Commits on Sep 16, 2024

  1. Add SettingsStore

    @paulhdk
    paulhdk committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    2a58323 View commit details
    Browse the repository at this point in the history

  2. Use keychain instead of UserDefaults in JustUpdatedChecker.swift

    @paulhdk
    paulhdk committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    70cfdf8 View commit details
    Browse the repository at this point in the history

  3. Add ability disable the SSH comment via settings

    @paulhdk
    paulhdk committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    4602296 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. Make SettingsStore functions non-static, re-implement them as 

    subscripts and make settingsStore an environmentObject

Fixes: maxgoedjen#536 (comment)
    @paulhdk
    paulhdk committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    a5a3f1c View commit details
    Browse the repository at this point in the history

  2. Add rawValues for CommentStyle enum

    @paulhdk
    paulhdk committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    5cbc4e5 View commit details
    Browse the repository at this point in the history

  3. Use SettingsStore for querying the comment style in SecretDetailView 

    Fixes: maxgoedjen#536 (comment)
    @paulhdk
    paulhdk committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    e29dd20 View commit details
    Browse the repository at this point in the history

  4. Revert "Use keychain instead of UserDefaults in JustUpdatedChecker.sw… 

    …ift"

This reverts commit ae8a21a.
    @paulhdk
    paulhdk committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    52f3fea View commit details
    Browse the repository at this point in the history

  5. Remove copyright info

    @paulhdk
    paulhdk committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    748fc4e View commit details
    Browse the repository at this point in the history

  6. Use "enum Constants" in SettingsStore

    @paulhdk
    paulhdk committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    77bf72e View commit details
    Browse the repository at this point in the history