generated from mattermost/mattermost-plugin-starter-template
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor calendar engine into its own package #267
Merged
Merged
Changes from 13 commits
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
00e1eb0
oauth works
mickmister 742a49c
autocomplete
mickmister 7f238a2
viewcal works
mickmister 19ff374
add unimplemented if blocks
mickmister 38ebd1f
Merge branch 'master' into migrate-to-gcal
mickmister a88921f
fix tests and lint
mickmister 8259bde
implement CreateMySubscription, RenewSubscription, and DeleteSubscrip…
mickmister 83db731
WIP gcal subs
mickmister b057dcf
setup-attach make target
mickmister 863cb37
Merge branch 'master' into gcal-merge
mickmister 38f3fdf
fix lint and tests
mickmister 9ed5ee6
chore: more compatible tar command
fmartingr d78381a
add review comments
mickmister 728630e
[GCAL] Create event logic (#269)
fmartingr 585e821
bug: get timezone from datetime instead of event data (#271)
fmartingr e30acd4
[GCAL] Allow building two different plugins under the same codebase (…
fmartingr b139719
[GCAL] Endpoint to autocomplete connected calendar users (#275)
fmartingr e3d6a94
[GCAL] Refactor Microsoft Calendar references to provider references …
fmartingr 336a906
[GCAL] Enable notifications and reminders when a superuser token is n…
fmartingr 34ca3ed
[GCAL] Added encrypted key value storage (#270)
fmartingr 421c8d5
[GCAL] today/tomorrow commands with styling (#273)
fmartingr f226b5e
[GCAL] Fix test in main branch from PR merges (#277)
fmartingr aa14450
[GCAL] Move configuration readyness logic to remotes (#279)
fmartingr d3fe76b
[GCAL] Remove unused code (#278)
fmartingr b345fef
[GCAL] Fix event notifications not working due to missing scope permi…
fmartingr eba9102
[GCAL] Unsubscriptions (#283)
fmartingr b3f4558
update gcal manifest (#285)
fmartingr 23a3f23
[GCAL] Better logging information (#287)
fmartingr 95c9a44
use correct manifest file on manifest calls (#290)
fmartingr 735fc05
[GCAL] Embed tzdata and correctly parse location from event datetime …
fmartingr c47dd5e
[GCAL] Event notifications behind a feature flag (#292)
fmartingr 7a45ad0
ignore notifications if there's no processor (#293)
fmartingr 7f673be
[GCAL] Remove join event column (broken from merges) (#294)
fmartingr 2a4ec5d
[GCAL] Channels reminder underlying logic (#274)
fmartingr 1ab957a
Updated google calendar readme
fmartingr 2ddf28b
[GCAL] Summary command fixes (#286)
fmartingr 4eda283
[GCAL] Add a modal to create events (#281)
mickmister 37a55c0
[GCAL/MSCAL] Store linked events per user to remove links on disconne…
fmartingr aeb352a
[GCAL/MSCAL] Remind only accepted events (#295)
fmartingr ac12e63
Remove GoogleDomainVerifyKey setting (#299)
fmartingr f8a8f75
fix: encrypt user store (#297)
fmartingr dc937e2
feat: send notifications when an event is created (#300)
fmartingr abd0eec
typo: user already connected message (#301)
fmartingr 1cc2149
typo: user already connected message (#301)
fmartingr 974d5d0
[GCAL/MSCAL] Exclude rejected events from agenda commands (#302)
fmartingr b6bed01
[GCAL/MSCAL] Create event modal only for connected accounts (#303)
fmartingr 39544fd
updated settings to use style and removed current value line (#305)
fmartingr 9ef367a
show link to connect if not connected (#306)
fmartingr 73dfe63
[GCAL/MSCAL] Reduce welcome steps (#308)
fmartingr 2bb4367
[GCAL/MSCAL] Control start/date times if the selected date is today (…
fmartingr 395cbfa
database replication workaround (#312)
fmartingr 6b8defa
[GCAL/MSCAL] Catch errors when using `findmeetings` commands without …
fmartingr 8a728fd
Replace Equals with ElementsMatch
fmartingr 8925e67
makefile dist build for production (#314)
fmartingr dfeb3d1
[GCAL/MSCAL] Create event UX improvements (#309)
fmartingr c1bd4d3
[GCAL] Store conference data (#298)
fmartingr 5ef3953
Common code refactor, back to mscalendar plugin (#334)
fmartingr 8b4065b
apped user to handle after all actions (#335)
fmartingr 3d0dc0b
refactor msgraph to mscalendar
fmartingr bf4cefe
Merge remote-tracking branch 'origin/master' into migrate-to-gcal
fmartingr 783c2f0
goimports
fmartingr ae5f3d8
removed apply command from merge
fmartingr 1de44d0
remove "REVIEW:" comments
mickmister File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
package command | ||
|
||
import ( | ||
"fmt" | ||
"testing" | ||
|
||
"github.com/golang/mock/gomock" | ||
|
@@ -30,8 +31,11 @@ func TestConnect(t *testing.T) { | |
mscal := m.(*mock_mscalendar.MockMSCalendar) | ||
mscal.EXPECT().GetRemoteUser("user_id").Return(&remote.User{Mail: "[email protected]"}, nil).Times(1) | ||
}, | ||
expectedOutput: "Your Mattermost account is already connected to Microsoft Calendar account `[email protected]`. To connect to a different account, first run `/mscalendar disconnect`.", | ||
expectedError: "", | ||
expectedOutput: fmt.Sprintf( | ||
"Your Mattermost account is already connected to %s account `[email protected]`. To connect to a different account, first run `/%s disconnect`.", | ||
config.ApplicationName, config.CommandTrigger, | ||
), | ||
expectedError: "", | ||
}, | ||
{ | ||
name: "user not connected", | ||
|
@@ -59,7 +63,7 @@ func TestConnect(t *testing.T) { | |
command := Command{ | ||
Context: &plugin.Context{}, | ||
Args: &model.CommandArgs{ | ||
Command: "/mscalendar " + tc.command, | ||
Command: fmt.Sprintf("/%s %s", config.CommandTrigger, tc.command), | ||
UserId: "user_id", | ||
}, | ||
ChannelID: "channel_id", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,6 +9,7 @@ import ( | |
"github.com/mattermost/mattermost-plugin-mscalendar/server/config" | ||
) | ||
|
||
// REVIEW: hardcoded "microsoft" | ||
func (c *Command) info(parameters ...string) (string, bool, error) { | ||
resp := fmt.Sprintf("Mattermost Microsoft Calendar plugin version: %s, "+ | ||
"[%s](https://github.com/mattermost/%s/commit/%s), built %s\n", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. config: plugin name |
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This we should take care as well.