Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support different time format preferences for the user #358

Open
mickmister opened this issue Mar 1, 2024 · 7 comments
Open

Support different time format preferences for the user #358

mickmister opened this issue Mar 1, 2024 · 7 comments
Assignees
Labels
Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers

Comments

@mickmister
Copy link
Contributor

Many of the posts made by this plugin have a reference to a start time of an event or events. For any post we send directly to a user, we can form the time string in a way that this user prefers the time to be shown. The plugin can also be given a default value, to use for any public posts.

To determine a user's time display preference, we can use the plugin API to get the user's preferences, then find the one with Category: model.PreferenceCategoryDisplaySettings and Name: model.PreferenceNameUseMilitaryTime

@mickmister mickmister added Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers labels Mar 1, 2024
@THEBOSS0369
Copy link

THEBOSS0369 commented Jul 31, 2024

Hi @mickmister i have recently started learning to contribute to open source in github, i am a beginner and this issue seems very interesting to me as my first contribution. so if no one is assigned to do this task can you assign this task to me ,so that i can start contributing to this. Till Now I have just commited my projects only so if this task takes time please don't mind me, i will give my all to complete this asap.

@THEBOSS0369 THEBOSS0369 removed their assignment Aug 3, 2024
@Tihomir-N
Copy link

Hi, @mickmister can I work on this task if it's still available?

@raghavaggarwal2308
Copy link
Contributor

@THEBOSS0369 Just for confirmation, are you working on this task?

@THEBOSS0369
Copy link

THEBOSS0369 commented Sep 2, 2024

@THEBOSS0369 Just for confirmation, are you working on this task?

Hey @raghavaggarwal2308 No sir ,i ain't working on this issue I carelessly asked for assignment even though I didn't knew this was in go(I have never coded in go). Someone deserving can work on this issue . Apologies for my stupid assignment request 😔

@wiggin77
Copy link
Member

wiggin77 commented Sep 2, 2024

Hi, @mickmister can I work on this task if it's still available?

@Tihomir-N Yes, it's all yours. Let me know if you need any assistance.

@Tihomir-N
Copy link

@wiggin77 Hi, I need some more details about this story. I see that you are already using the current time zone when preparing the context in mapStateToProps for the users. Can you clarify where additionally I should apply the logic for the time. Some more details and perhaps a screenshot would be of great help. Thanks in advance. 😃

@wiggin77
Copy link
Member

wiggin77 commented Sep 11, 2024

@Tihomir-N. The original submitter was the plugin maintainer but is unavailable for a while. I believe what he is looking for is to display event notifications, reminder, etc that are posted as a DM to users in the format that users have set in their profile.
Screenshot from 2024-09-11 18-37-42

This setting can be fetched with the API linked in description for this ticket --> To determine a user's time display preference, we can use the plugin API to get the user's preferences, then find the one with Category: model.PreferenceCategoryDisplaySettings and Name: model.PreferenceNameUseMilitaryTime

The task is a matter of finding the places where this plugin generates a direct message to users, look up the user preference, and format the event timestamp accordingly. There is a specific API to send a direct message - searching the code for that would likely find the places that need this change. I doubt there are many.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers
Projects
None yet
Development

No branches or pull requests

5 participants