Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

summary time requires capitalization in AM / PM #339

Open
coltoneshaw opened this issue Oct 11, 2023 · 2 comments · May be fixed by #438
Open

summary time requires capitalization in AM / PM #339

coltoneshaw opened this issue Oct 11, 2023 · 2 comments · May be fixed by #438
Labels
Good First Issue Suitable for first-time contributors Hacktoberfest

Comments

@coltoneshaw
Copy link
Member

When using /gcal summary time it requires you to put 9:00AM instead of 9:00am, for example.

so the below is invalid:

/gcal summary time 9:00am

and this is valid.

/gcal summary time 9:00AM

Expected:

Accept am or AM.
@fmartingr fmartingr added Good First Issue Suitable for first-time contributors Hacktoberfest labels Oct 13, 2023
@fmartingr fmartingr transferred this issue from mattermost/mattermost-plugin-google-calendar Oct 13, 2023
@Harsh1s
Copy link

Harsh1s commented Oct 14, 2023

When using /gcal summary time it requires you to put 9:00AM instead of 9:00am, for example.

so the below is invalid:

/gcal summary time 9:00am

and this is valid.

/gcal summary time 9:00AM

Expected:

Accept am or AM.

Hi there! I'd like to be assigned this issue.

@Kshitij-Katiyar
Copy link
Contributor

@Harsh1s Are you still willing to pick this issue?

@Kshitij-Katiyar Kshitij-Katiyar linked a pull request Nov 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Suitable for first-time contributors Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MM-339]: Added support for lower case meridiems(AM/PM) mattermost/mattermost-plugin-mscalendar
4 participants
@fmartingr @coltoneshaw @Harsh1s @Kshitij-Katiyar