Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the Id-based NoiseVehicle lookup by introducing a NoiseVehicleType #3570

Open
tschlenther opened this issue Nov 18, 2024 · 1 comment

Comments

@tschlenther
Copy link
Contributor

[emerges from #3519 ]
[related to #3569 ]

There is NoiseVehicleIdentifier which currently looks up the VehicleId and compares it with an Id-Set that is user-configured in NoiseConfigGroup.
This is brittle.

Similarly to HbefaVehicleType. we could introduce a NoiseVehicleType and then do the lookup simply by using instanceof.
Alternatively, one could check for introducing HeavyGoodsVehicleType(s) and see whether we can use them across both the noise and the emissions contrib.

@kt86
Copy link
Contributor

kt86 commented Nov 30, 2024

I am in favor of option 1: NoiseVehicleType

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo (low priority)
Development

No branches or pull requests

2 participants