Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the update_repo script check for updates to itself #6

Open
callahad opened this issue Jul 29, 2021 · 2 comments
Open

Have the update_repo script check for updates to itself #6

callahad opened this issue Jul 29, 2021 · 2 comments

Comments

@callahad
Copy link
Contributor

To ensure that bugfixes are picked up, the release script should attempt to verify that its checkout of this repo is up to date.

@babolivier
Copy link
Contributor

By release script, are you referring to Synapse's release script in Synapse's repo? Or the script to publish debs in this repo?

If it's the latter, we could probably just have it run git pull at the start of the run.

@richvdh richvdh changed the title Have the release script check for updates to itself Have the update_repo script check for updates to itself Aug 2, 2021
@richvdh
Copy link
Member

richvdh commented Aug 2, 2021

Yeah this refers to the script to update the repository.

If it's the latter, we could probably just have it run git pull at the start of the run.

Probably, but that assumes that you're working on the right branch etc. I'd prefer it to check if it was on the same commit as upstream HEAD, and bomb out if not (unless you give it a --force option)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants