fix(crypto): Don't warn about verified users when subscribing to identity updates #4134
+130
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
force-pushed
the
andybalaam/extract-simulate_key_query_response_for_verification
branch
from
6ad623f
to
a9d4ac2
Compare
andybalaam
force-pushed
the
andybalaam/dont-emit-verified-identities-at-start-of-stream
branch
from
10d47f7
to
0c7ef62
Compare
andybalaam
force-pushed
the
andybalaam/dont-emit-verified-identities-at-start-of-stream
branch
from
0c7ef62
to
1d57b6f
Compare
andybalaam
force-pushed
the
andybalaam/extract-simulate_key_query_response_for_verification
branch
from
a9d4ac2
to
67d147b
Compare
andybalaam
force-pushed
the
andybalaam/dont-emit-verified-identities-at-start-of-stream
branch
from
1d57b6f
to
24290b1
Compare
Base automatically changed from
andybalaam/extract-simulate_key_query_response_for_verification
to
main
October 18, 2024 10:37
andybalaam
force-pushed
the
andybalaam/dont-emit-verified-identities-at-start-of-stream
branch
from
24290b1
to
f0fb72e
Compare
|
Sorry for force-pushing - github wasn't triggering the checks. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4134 +/- ##
==========================================
+ Coverage 84.83% 84.85% +0.01%
==========================================
Files 269 269
Lines 28798 28802 +4
==========================================
+ Hits 24430 24439 +9
+ Misses 4368 4363 -5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you enter a room, your UI will subscribe to the identity change updates. The first update it receives gives the "current state" of the room members.
Before this change, that first update would include verified users.
After this change, it only includes users you need to warn about: unpinned users and those in verification violation.
This supplies only the information the UI needs to warn the user.
Fixes #4104