Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VASP command with more than 1 line #272

Open
JaGeo opened this issue Jul 19, 2023 · 5 comments
Open

VASP command with more than 1 line #272

JaGeo opened this issue Jul 19, 2023 · 5 comments
Labels
discussion Discussion of new features/proposed changes

Comments

@JaGeo
Copy link
Member

JaGeo commented Jul 19, 2023

It's currently not possible to use a VASP (or Lobster) command including more than 1 line (e.g., to change the number of threads within one job script).

I did not find a solution that is easy to implement yet and wanted to ask if there is an interest in such a feature and/or if someone has ideas on how to implement it.

Can anyone think of a command that could easily replace this one here?

return subprocess.Popen(cmd, stdout=f_std, stderr=f_err, start_new_session=True) # pylint: disable=R1732

@janosh
Copy link
Member

janosh commented Jul 22, 2023

What's the issue with a multiline VASP command?

@janosh janosh added the discussion Discussion of new features/proposed changes label Jul 22, 2023
@JaGeo
Copy link
Member Author

JaGeo commented Jul 22, 2023

It's not working to provide a command longer than 1 line with popen.

@janosh
Copy link
Member

janosh commented Jul 22, 2023

What if we refactor cmd to be list instead of str?

@JaGeo
Copy link
Member Author

JaGeo commented Jul 22, 2023

Would this work in combination with a typical configuration file?

@janosh
Copy link
Member

janosh commented Jul 22, 2023

Sorry, didn't read carefully. Actually cmd is already a list

cmd = list(self.vasp_cmd)

@janosh janosh closed this as completed Jul 22, 2023
@janosh janosh reopened this Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussion of new features/proposed changes
Projects
None yet
Development

No branches or pull requests

2 participants