-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Command line argument 'vasp_gam' was not understood. #265
Comments
@ryotatomioka Thanks for the repro and great analysis! +1 for making |
Good catch @ryotatomioka , and sorry for messing this up. I tried to stick to the old terminate functionality, but messed up at least one indentation. Maybe more. @janosh , I am happy to make the commands immutable in a PR, but probably this can be included in #264, since this also has to do with termination. What do you think? |
@MichaelWolloch Yes, if @fyalcin would like to include a fix for this in #264, that'd be great! |
When reporting bugs/issues, please supply the following information. If this
is a feature request, please simply state the requested feature.
System
Summary
I believe a bug was introduced in this commit around these lines
custodian/custodian/vasp/jobs.py
Lines 689 to 696 in f7dc11a
The problem is that both
self.vasp_cmd
andself.gamma_vasp_cmd
can be lists! In this case,self.gamma_vasp_cmd
is appended toself.vasp_cmd
every timeterminate
method is called. This is the case whencustodian
is called fromatomate2
. See:https://github.com/materialsproject/atomate2/blob/02e44c038903d2c935c82b31afd8ab82a69c039e/src/atomate2/vasp/run.py#L86-L170
This results in
For some reason, custodian does not see this as an error and keep applying the same correction until the maximum number of corrections are used resulting in a confusing error message. It would be better if we can improve the error message as well.
Example code
Error message
Suggested solution (if known)
Files
<If input files are needed for the error, please copy and paste them here.>
The text was updated successfully, but these errors were encountered: