Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difficult to find the Export 3D object option #347

Open
computron opened this issue Jun 20, 2023 · 2 comments
Open

Difficult to find the Export 3D object option #347

computron opened this issue Jun 20, 2023 · 2 comments
Labels
javascript Pull requests that update Javascript code ui Styles, CSS, interactivity controls

Comments

@computron
Copy link
Member

The export 3D format option is currently under the snapshot sidebar and not under the Export sidebar. It makes it difficult to find or discover that the crystal can be exported to 3D formats. Suggest moving it to the export button. The snapshot icon to me means more like copying image to clipboard.

@janosh
Copy link
Member

janosh commented Jun 20, 2023

I think the current split is based on media vs non-media exports. The export icon only shows readable export formats.

Screenshot 2023-06-20 at 2 43 28 PM

I'm not sure this separation is helpful. I think we could throw it all together into a single "Export" dropdown.

This would need to be changed in https://github.com/materialsproject/mp-react-components.

@janosh janosh added javascript Pull requests that update Javascript code ui Styles, CSS, interactivity controls labels Jun 20, 2023
@mkhorton
Copy link
Member

mkhorton commented Aug 1, 2023

The distinction perhaps makes more sense for the developer than from the user: bitmap or 3D graphics exports are handled client-side by Three.js, whereas the file exports are handled serverside via pymatgen.

They call completely different code paths. Combining them into a single dropdown is therefore a little trickier, because it would require hard-coding some things in JavaScript that are currently defined dynamically via Python (the pymatgen output formats).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code ui Styles, CSS, interactivity controls
Projects
None yet
Development

No branches or pull requests

3 participants