Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VASP rule: if LELF=True then NPAR=NCORE=1 #423

Open
Andrew-S-Rosen opened this issue Jul 4, 2023 · 7 comments
Open

VASP rule: if LELF=True then NPAR=NCORE=1 #423

Andrew-S-Rosen opened this issue Jul 4, 2023 · 7 comments

Comments

@Andrew-S-Rosen
Copy link
Member

Andrew-S-Rosen commented Jul 4, 2023

The VASP manual states that if LELF is set to True, NPAR (and NCORE) should be 1. Let's add a check for that in https://github.com/materialsproject/atomate2/blob/main/src/atomate2/vasp/sets/base.py

Source: https://www.vasp.at/wiki/index.php/LELF

@Andrew-S-Rosen
Copy link
Member Author

Tagging @matthewkuner, enjoyer of all things INCAR flags.

@matthewkuner
Copy link
Collaborator

Does this affect results, speed, or whether or not anything will run at all?

@Andrew-S-Rosen
Copy link
Member Author

I have absolutely zero clue 😅

@JaGeo
Copy link
Member

JaGeo commented Jul 7, 2023

We can add that check. Same is btw True for Lepsilon=True computations. NPAR=1 needs a lot more memory, however.

ELF computations had a bug in one of the latest VASP versions. Not sure it's patched.

@JaGeo
Copy link
Member

JaGeo commented Jul 7, 2023

And, @arosen93 , have you seen this? https://www.vasp.at/forum/viewtopic.php?t=16792

@JaGeo
Copy link
Member

JaGeo commented Jul 7, 2023

This is the patch, btw: https://github.com/Chengcheng-Xiao/VASP_LOL

@utf
Copy link
Member

utf commented Aug 14, 2023

These fixes seem like things that should be added to custodian? Perhaps they already are?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants