-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VASP rule: if LELF=True
then NPAR=NCORE=1
#423
Comments
Tagging @matthewkuner, enjoyer of all things INCAR flags. |
Does this affect results, speed, or whether or not anything will run at all? |
I have absolutely zero clue 😅 |
We can add that check. Same is btw True for ELF computations had a bug in one of the latest VASP versions. Not sure it's patched. |
And, @arosen93 , have you seen this? https://www.vasp.at/forum/viewtopic.php?t=16792 |
This is the patch, btw: https://github.com/Chengcheng-Xiao/VASP_LOL |
These fixes seem like things that should be added to custodian? Perhaps they already are? |
The VASP manual states that if
LELF
is set toTrue
,NPAR
(andNCORE
) should be 1. Let's add a check for that in https://github.com/materialsproject/atomate2/blob/main/src/atomate2/vasp/sets/base.pySource: https://www.vasp.at/wiki/index.php/LELF
The text was updated successfully, but these errors were encountered: