-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also have node_modules/ taglibs default to ./components
?
#1401
Comments
In this case are you hoping to avoid having a |
No, I had a |
I agree. We should make this change. |
Thinking this through a bit more, this would actually be a breaking change. Also I think in a lot of cases packages may opt for something like |
I would be fine if it gave an error message saying “it looks like you’re trying to use these components, but you have to use an explicit |
I think that's something we could do. Basically if a |
Marko Version: 4.18.10
Details
When using a Marko project in a root project, components will automatically be discovered at
./components
.When using a custom taglib from
node_modules/
, the compiler requires"tags-dir"
to be defined.Expected Behavior
I assumed as long as
marko.json
existed, the autoloader would reuse the./components
convention.Possible Fix
Either this difference should be more clearly documented, OR
The autoloader should also have a default of
.components
if"tags-dir"
isn’t defined. I’d much prefer this option.Steps to Reproduce
https://github.com/tigt/marko-cant-import-internal-package-repro
Stack Trace
The text was updated successfully, but these errors were encountered: