Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain WASM size through Github Action #89

Open
maxammann opened this issue May 9, 2022 · 2 comments · May be fixed by #88
Open

Explain WASM size through Github Action #89

maxammann opened this issue May 9, 2022 · 2 comments · May be fixed by #88
Labels
feature-request Request for a new feature good first issue Good for newcomers

Comments

@maxammann
Copy link
Collaborator

maxammann commented May 9, 2022

Goal of this task is to give some more insights into the size of the wasm/native binary.

Note: This is a beginner task because it requires no insight into maplibre-rs. But its probably not tivial.

🤔 Expected Behavior

  • We want a cargo profile, which includes debug symbols, but is else identical to a release build. This gives a good estimate of actual sizes and allows to debug the usage.
  • Track wasm size through a custom Github Action. Post diffs in the PR.

😯 Current Behavior

No insights.

💁 Possible Solution

There is https://github.com/orf/cargo-bloat-action/tree/master/src
Sadly this does not support WASM. Also it sends data to some cloudflare service in the US.

🔦 Context

💻 Examples

@maxammann maxammann added the feature-request Request for a new feature label May 9, 2022
@maxammann maxammann linked a pull request May 9, 2022 that will close this issue
1 task
@maxammann maxammann changed the title Explain WASM size Explain WASM size through Github Action Jun 3, 2022
@maxammann maxammann added the good first issue Good for newcomers label Jun 3, 2022
@maxammann
Copy link
Collaborator Author

I created a PR which covers the first task of this PR. Create binaries in release mode with debug symbols.

@maxammann
Copy link
Collaborator Author

Twiggy has a bug right now: rustwasm/twiggy#326

@maxammann maxammann added this to the Far far future milestone Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for a new feature good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant