Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update reverse operations to Python3 #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davidxbors
Copy link
Contributor

Up until now all reverse operations needed Python2 to run. This lead to a user needing to have 2 different versions of Python installed on their system. Now, only Python3 is required to run all Sandblaster operations.

@davidxbors davidxbors requested a review from razvand November 30, 2022 18:41
Copy link
Member

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @davidxbors, see my minor comments. I'll test this more extensively and then come back with another round of review.

reverse-sandbox/operation_node.py Outdated Show resolved Hide resolved
reverse-sandbox/sandbox_regex.py Outdated Show resolved Hide resolved
reverse-sandbox/reverse_sandbox.py Outdated Show resolved Hide resolved
reverse-sandbox/regex_parser_v3.py Outdated Show resolved Hide resolved
reverse-sandbox/regex_parser_v1.py Outdated Show resolved Hide resolved
@davidxbors davidxbors force-pushed the update-reverse-to-python3 branch from 2d9fbaa to e41ab93 Compare March 5, 2023 12:25
Copy link
Member

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidxbors, there are still places where this doesn't work on Python3. I'm doing testing now to (hopefully) get all places that require updates.

Up until now all reverse operations needed `Python2` to run. This lead
to a user needing to have 2 different versions of Python installed on their
system. Now, only `Python3` is required to run all `Sandblaster` operations.

Signed-off-by: David Bors <[email protected]>
@davidxbors davidxbors force-pushed the update-reverse-to-python3 branch from 852c60d to aca1685 Compare March 8, 2023 06:36
@davidxbors davidxbors requested a review from razvand March 8, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants