Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit #14

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add pre-commit #14

wants to merge 3 commits into from

Conversation

radudum10
Copy link
Contributor

Copy link
Member

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @radudum10 , thanks for this.

Some comments:

  • Please use your full name in commits, i.e. Radu Dumitru <[email protected]>. You can use git commit --amend to fix a commit and git rebase -i <parent_commit_id> to rebase to a particular commit.
  • Enhance the commit messages. For example the Add config file (with hooks) could be renamed to Add pre-commit configuration followed by a detailed description of pre-commit support.
  • Split the update README.md PR and add the part of the README.md talking about pre-commit to the commit above.
  • Follow the Markdown guidelines for README.md. Particularly, be sure to have one (and only one) full sentence per line.
  • See the issues reported by the automated checks from GitHub actions in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants