-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New device ezaiot_r9lite_thermostat.yaml #2631
base: main
Are you sure you want to change the base?
Conversation
Electric heating thermostat 16A version https://www.aliexpress.com/item/1005006020556081.html
@@ -0,0 +1,219 @@ | |||
name: EZAIOT R9Lite thermostat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name should just be generic (Thermostat), the branding belongs under products where it is linked to a specific product id.
name: temperature | ||
range: | ||
min: 50 | ||
max: 10000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really, 1000 degrees?
name: unknown_112 | ||
- id: 102 | ||
type: integer | ||
name: Temperature adjust step |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
attribute names should not have spaces or capital letters
name: Temperature adjust step | ||
- id: 110 | ||
type: boolean | ||
name: Valve state boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be hvac_action, with a mapping to "idle" and "heating"
value: Daily | ||
- entity: binary_sensor | ||
name: Valve | ||
class: opening |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid classes for valve are "water" and "gas".
type: bitfield | ||
name: fault_code | ||
- entity: number | ||
name: High temperature limit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Maximum temperature" is probably a better name.
- scale: 10 | ||
step: 10 | ||
- entity: number | ||
name: Low temperature limit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And "Minimum temperature"
step: 1 | ||
- entity: sensor | ||
#The dps id 113 is readonly (set not working)- I don't know why..probably not implemented on device | ||
name: Temperature sensor type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this needs to be a sensor. It can just be an attribute of the climate entity.
type: string | ||
name: sensor | ||
- entity: sensor | ||
name: External sensor current temperature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name is a bit long. "External temperature" is probably clear enough.
mapping: | ||
- scale: 10 | ||
- entity: sensor | ||
name: Version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also doesn't need to be a sensor, and should just be an attribute of the climate entity.
Electric heating thermostat 16A version https://www.aliexpress.com/item/1005006020556081.html