Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Readme #92

Open
marcospgp opened this issue Apr 9, 2018 · 1 comment
Open

Fix Readme #92

marcospgp opened this issue Apr 9, 2018 · 1 comment

Comments

@marcospgp
Copy link

marcospgp commented Apr 9, 2018

min: Boolean — preserving aspect ratio, resize the image to be as small as possible while ensuring its dimensions are greater than or equal to the width and height specified.

This part of the readme is missing a default value for the min option.

Cheers!

Edit: also, what happens if both min and max are defined?

Edit 2: I noticed there are links to the sharp documentation, but they are broken 😟 there is a pull request with the fixes! Please accept it 😄

@marcospgp marcospgp changed the title (Fast one) Fix Readme Fix Readme Apr 9, 2018
@feliperobledo
Copy link

feliperobledo commented Jan 14, 2020

Hello!
First off, thanks a lot for making this package in the first place.

As for the ask above, I would remove the following:

If you are using Mac OS then before installing `gulp-responsive` you should install the libvips library

sharp will install its own version of libvips in your system, at least on macOS.

By manually installing libvips ourselves, we pulled version 8.9.0. If that is present, sharp's installation process breaks because it is expecting version 8.8.1.

Furthermore, to install the latest version of sharp, you need to be on node 12.*.

Please let me know if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants