Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pwa 2968::[Issue] Gomage/plugin braintree three d secure #4311

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

glo82145
Copy link
Collaborator

@glo82145 glo82145 commented Aug 8, 2024

Description

TODO: Gomage/plugin braintree three d secure.

Related Issue

Closes #PWA-2968.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Aug 8, 2024

Warnings
⚠️ Found the word "TODO" in the PR description. Just letting you know incase you forgot :)
Messages
📖

Associated JIRA tickets: PWA-2968.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 8bf8c5b

@glo82145 glo82145 changed the title Pwa 2968 v1 Pwa 2968::[Issue] Gomage/plugin braintree three d secure Aug 9, 2024
@glo42707 glo42707 added the version: Major This changeset includes incompatible API changes and its release necessitates a Major version bump. label Aug 12, 2024
}
},
"trusted-vendors": [
"@gomage"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this get pulled into @magento instead? Alternatively anything published as gomage https://www.npmjs.com/search?q=gomage would come into scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:extensions pkg:pwa-buildpack pkg:venia-concept pkg:venia-ui Progress: ready for review version: Major This changeset includes incompatible API changes and its release necessitates a Major version bump.
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

7 participants