Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gas limit to calls of a controller with only SUPER_TRANSFERVALUE permission #159

Open
skimaharvey opened this issue Jan 11, 2023 · 1 comment

Comments

@skimaharvey
Copy link
Member

In the rare event some contracts have code within their receive()/fallback() functions, SUPER_TRANSFERVALUE could be used to initiate calls from these fonctions.

One way to prevent it could be by limiting the gas of a transfer made by controller that has the SUPER_TRANSFERVALUE permission does not have the required CALL/SUPER_CALL permission.

@skimaharvey skimaharvey changed the title Add gas limit to calls of a controller with only SUPER_TRANSFERVALUEpermission Add gas limit to calls of a controller with only SUPER_TRANSFERVALUE permission Jan 11, 2023
@YamenMerhi
Copy link
Member

Since reverting when a controller exceeds a specific gas limit when transferring value is the intention, I don't see a strong reason to implement this on the smart contract level, when a a controller can specify this gasLimit for the whole tx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants