Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LSP6] Should we split permission for SETDATA, into ADDDATA and EDITDATA #110

Open
frozeman opened this issue Aug 22, 2022 · 1 comment
Open

Comments

@frozeman
Copy link
Member

TBD

@frozeman frozeman changed the title [LSP-6] Should we split permission for SETDATA, into ADDDATA and EDITDATA [LSP6] Should we split permission for SETDATA, into ADDDATA and EDITDATA Aug 22, 2022
@frozeman frozeman changed the title [LSP6] Should we split permission for SETDATA, into ADDDATA and EDITDATA [LSP6] Should we split permission for SETDATA, into ADDDATA and EDITDATA Aug 22, 2022
@YamenMerhi
Copy link
Member

I don't have any usecase in mind for separating SETDATA into Add/EDIT Data, but i see we do that for the other permissions as well.

So might be worth it to think about introducing it. The only thing that i would recommend is on the smart contract level when a controller have both permissions, do net query the data key to check if there is something written there, as controller have both permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants