RegistryApi.register_schema always talks to Schema Registry when supplied a subject #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit of a hack to be able to specify different responses for consecutive requests. If we want something more flexible than this, we should look at integrating something like "aioresponses" instead
Failed b.c we now make 2 requests in register_schema when using subjects
Open
|
Sorry we haven't been able to work out this PR. We'll be restarting development on Kafkit this year so I'm at long last taking a look at in issue in #4. This might be an API design issue in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
Previously, when calling
RegistryApi.register_schema(), it short-circuited and directly sent back the schema_id if the schema already existed in the schema_cache, regardless if we supplied a subject/schema combination that didn't previously exist.This had the effect that the new subject never got created in the Schema Registry, and we didn't have the subject in the subject_cache in RegistryApi either.
This attempts to solve that problem