Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shares namespace with MessageBus #5

Open
mikz opened this issue Aug 8, 2017 · 1 comment
Open

Shares namespace with MessageBus #5

mikz opened this issue Aug 8, 2017 · 1 comment

Comments

@mikz
Copy link
Contributor

mikz commented Aug 8, 2017

This gem can't be loaded together with message_bus. Loading this gem will cause message_bus to crash:

ArgumentError (wrong number of arguments (given 2, expected 1)):
  message_bus-client (0.1.0) lib/message_bus/client/message_handler.rb:29:in `subscribe'
  message_bus (2.0.2) lib/message_bus/rack/middleware.rb:104:in `block in call'
  message_bus (2.0.2) lib/message_bus/rack/middleware.rb:100:in `each'
  message_bus (2.0.2) lib/message_bus/rack/middleware.rb:100:in `call'

Because it redefines MessageBus::Client.

This gem should not reuse MessageBus namespace and use its own to prevent conflicts.

mikz added a commit to 3scale/message_bus_client that referenced this issue Aug 8, 2017
mikz added a commit to 3scale/message_bus_client that referenced this issue Aug 9, 2017
mikz added a commit to 3scale/message_bus_client that referenced this issue Aug 9, 2017
mikz added a commit to 3scale/message_bus_client that referenced this issue Aug 9, 2017
mikz added a commit to 3scale/message_bus_client that referenced this issue Aug 11, 2017
mikz added a commit to 3scale/message_bus_client that referenced this issue Aug 11, 2017
@lowjoel
Copy link
Owner

lowjoel commented Aug 19, 2017

Wow. This is painful. I imagine that most related gems share namespaces instead of making them disjoint. I can't seem to think of any alternative that does not require a renaming of the gem. I'll have to consider this further.

However, feel free to rename it as you'd like for your own use in the meanwhile.

mikz added a commit to 3scale/message_bus_client that referenced this issue Aug 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants