Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should be possible to get client id #1

Open
ffabreti opened this issue May 17, 2016 · 3 comments · May be fixed by #2
Open

should be possible to get client id #1

ffabreti opened this issue May 17, 2016 · 3 comments · May be fixed by #2
Labels

Comments

@ffabreti
Copy link

there are use cases where client needs to send client_id to the server

would that be possible with message_bus-client ?

@ffabreti ffabreti linked a pull request May 17, 2016 that will close this issue
@lowjoel
Copy link
Owner

lowjoel commented May 30, 2016

I'm not entirely sure that exporting the client ID is necessarily a good thing. I think that that this library should emulate the JS API.

If discourse/message_bus#85 is closed with the API added, I would support adding this. However, if it takes a different route, I'd prefer to follow that.

@ffabreti
Copy link
Author

SamSaffron/message_bus#85 doesn't need to be closed, because anyone can get or set MessageBus.client_id at the current API.
I mean, right now, your lib is not emulating JS API behavior.

@lowjoel
Copy link
Owner

lowjoel commented May 30, 2016

Hmm, to me that is currently an undocumented feature and is purely implementation specific. It would be no different if you used instance_variable_get and instance_variable_set to achieve what you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants