[prim_fifo_sync,fpv+rtl] Add checks for the full_o output #25464
+37
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit silly, but the storage of an empty fifo is always full for rather trivial reasons. The existing connection didn't really make sense (because it was considered full if something was able to read from it!) so I'm pretty certain this won't break anything. Signed-off-by: Rupert Swarbrick <[email protected]>
rswarbrick
added
Component:FPV
rswarbrick
requested review from
hcallahan-lowrisc
and removed request for
a team
Signed-off-by: Rupert Swarbrick <[email protected]>
rswarbrick
force-pushed
the
prim-fifo-sync-full-checks
branch
from
ee4eac8
to
4c7359a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on #25461, I noticed that we didn't have any assertions about the behaviour of the
full_ooutput port. This PR adds those assertions in the second commit, and makes them true (in a trivial way) in the first.