[rv_dm,sival] Fix rv_dm_mem_access_dev_rv_dm_delayed_enable
#25460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `rv_dm_mem_access` test was not working in the
`dev_rv_dm_delayed_enable` test configuration. This is because the test
was not written to handle the additional logic required for this
configuration.
To fix this, before the host side attempts to connect via JTAG, it waits
for a message ("DEBUG_MODE_ENABLED") from the device, which will
configure the RV DM to enable the late debug feature (debug mode). This
should only be available using the OTP image with the late_debug feature
enabled, in the `delayed_enable` test configuration.
Signed-off-by: Alex Jones <[email protected]>
AlexJones0
added
the
CherryPick:earlgrey_1.0.0
AlexJones0
requested review from
jwnrt,
pamaury,
nbdd0121 and
engdoreis
and removed request for
jon-flatley and
jwnrt
AlexJones0
changed the title
rv_dm_mem_access_delayed_enablerv_dm_mem_access_dev_rv_dm_delayed_enable
engdoreis
approved these changes
Nov 29, 2024
|
CI failure is due to current CI outage issues, this change should only affect the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rv_dm_mem_accesstest was not working in thedev_rv_dm_delayed_enabletest configuration. This is because the test was not written to handle the additional logic required for this configuration.To fix this, before the host side attempts to connect via JTAG, it waits for a message ("
DEBUG_MODE_ENABLED") from the device, which will configure the RV DM to enable the late debug feature (debug mode). This should only be available using the OTP image with the late debug feature enabled, in thedelayed_enabletest configuration.This has been tested to pass consistently on a CW310 by running the following command:
./bazelisk.sh test -t- --test_output=streamed --build_tests_only --runs_per_test=5 --test_tag_filters=cw310 //sw/device/tests:rv_dm_mem_access