Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]Question about raft.leaderHasQuorum function call setNotActive #336

Open
fishjam opened this issue Dec 14, 2023 · 2 comments
Open

Comments

@fishjam
Copy link

fishjam commented Dec 14, 2023

Dragonboat version

  • master
  • tag v3.3.8

Expected behavior

  • when cluster setup, the remote's active status should not changed by wrong.

Steps to reproduce the behavior

  • add log in leaderHasQuorum , and use helloworld to monitor.
  • according the log, leaderHasQuorum will set remote.active status , maybe it's wrong?
  • or what's the purpose of active? Is it used to indicate whether the remote is valid (can send heartbeats and receive responses)?

image

@lni
Copy link
Owner

lni commented Dec 14, 2023

or what's the purpose of active? Is it used to indicate whether the remote is valid (can send heartbeats and receive responses)?

It means the remote side sent some responses back since the last call to leaderCheckQuorum()

@lni
Copy link
Owner

lni commented Dec 14, 2023

do you want to send in a PR to add some comments on the meaning of this flag?

thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants