Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse: add new option to throw when parameterLimit is reached #515

Closed
ljharb opened this issue Oct 27, 2024 · 7 comments · Fixed by #517
Closed

parse: add new option to throw when parameterLimit is reached #515

ljharb opened this issue Oct 27, 2024 · 7 comments · Fixed by #517

Comments

@ljharb
Copy link
Owner

ljharb commented Oct 27, 2024

Perhaps instead, add a new option that throws whenever any limit is reached, including arrayLimit.

See expressjs/express#5878

@IamLizu
Copy link
Contributor

IamLizu commented Nov 12, 2024

Hey @ljharb 👋

I would like to work on this.

@ljharb
Copy link
Owner Author

ljharb commented Nov 12, 2024

@IamLizu no need to "claim" issues in open source :-) just make a PR for anything that has a "help wanted" label

@IamLizu
Copy link
Contributor

IamLizu commented Nov 12, 2024

Hey @ljharb 👋

Can we do the implement the arrayLimit check in a different PR? If yes, I would enable #517 for review.

Edit: Yes, we can implement a single option to handle throw for both cases with clear message of which one exceeded. But I was wondering if that could be a re-factor on this.

@ljharb
Copy link
Owner Author

ljharb commented Nov 12, 2024

I think it'd be important to add it in the same PR, otherwise we'd need two options (to not be a breaking change)

@IamLizu
Copy link
Contributor

IamLizu commented Nov 12, 2024

(sorry, copying from previous comment)

Yes, we can implement a single option to handle throw for both cases with clear message of which one exceeded. But I was wondering if that could be a re-factor on this.

@ljharb
Copy link
Owner Author

ljharb commented Nov 12, 2024

If it's released with support for only one limit, then it can't ever support a second limit without a breaking change.

@IamLizu
Copy link
Contributor

IamLizu commented Nov 12, 2024

Agreed 🤝

And thanks for the early review on the PR 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants