Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version comparison might not be working correctly #127

Open
Guldoman opened this issue Oct 1, 2024 · 2 comments
Open

Version comparison might not be working correctly #127

Guldoman opened this issue Oct 1, 2024 · 2 comments

Comments

@Guldoman
Copy link
Member

Guldoman commented Oct 1, 2024

For example here the explicit repo contains the plugin at version 0.1.11, while our main repo contains 0.1.2, but lpm seems to consider 0.1.2 as newer than 0.1.11:

$ lpm run --ephemeral https://github.com/drmargarido/lite-xl-plugins:master todotreeview
warning: your explicitly specified repository https://github.com/drmargarido/lite-xl-plugins:master has a version of todotreeview lower than that in https://github.com/lite-xl/lite-xl-plugins.git:master (0.1.11 vs. 0.1.2; in order to use the one in your specified repo, please specify todotreeview:0.1.11
@adamharrison
Copy link
Member

I don't get this error on master. Do you still get it?

@Guldoman
Copy link
Member Author

Nop this is still happening.
The reason you're not getting the warning is because the change was merged, so both repos have the same todotreeview version.
Manually editing the saved "main" repo to have the old version 0.1.2, will result in the warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants