Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newly added files can't be directly pushed #45

Open
MQQ opened this issue Mar 10, 2019 · 1 comment
Open

Newly added files can't be directly pushed #45

MQQ opened this issue Mar 10, 2019 · 1 comment

Comments

@MQQ
Copy link
Collaborator

MQQ commented Mar 10, 2019

It seems that change to an existing file in the repo can be git bigstore push correctly, but if I git add/stage a NEW file and add that file to .gitattributes, the git bigstore push won't directly work. I think the reason is that in the pathnames() function, it uses ls_tree to list all the files, but a new file won't be listed here since it hasn't been added to the tree?

I guess one way to solve that is to use ls_files with the stage option instead to list all the files. But I am not sure whether I missed something or I misunderstood the intentional workflow.

If this is actually a problem, I am happy to submit a patch.

@dlo
Copy link
Member

dlo commented Mar 13, 2019

Hmm, interesting. This might be a bug; do you have a good reproducible test case we can test against? I think the intended behavior should be what you're describing though, a patch would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants