Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 support #40

Closed
dlo opened this issue Mar 3, 2018 · 9 comments
Closed

Python 3 support #40

dlo opened this issue Mar 3, 2018 · 9 comments
Assignees
Milestone

Comments

@dlo
Copy link
Member

dlo commented Mar 3, 2018

No description provided.

@dlo dlo added the enhancement label Mar 3, 2018
@dlo dlo added this to the Next Release milestone Mar 3, 2018
@dlo dlo added the help wanted label Mar 3, 2018
@MQQ
Copy link
Collaborator

MQQ commented Jan 23, 2019

Hi there, just want to check if there is any plan or effort for this. If not, I can try to help. Thanks!

@dlo
Copy link
Member Author

dlo commented Jan 23, 2019

Hey @MQQ! So far, I haven't had the time, but if you're willing to, I'd be super happy to accept any PRs. :) Thank you!

@dlo dlo pinned this issue Jan 23, 2019
@MQQ
Copy link
Collaborator

MQQ commented Jan 23, 2019

ok, I will see what I can do in the next week or two. :)

@MQQ
Copy link
Collaborator

MQQ commented Jan 25, 2019

@dlo Here is a quick PR for 2/3 compatible. #43

Notes:

  1. The biggest problem is that python-cloudfiles is a very outdated package, and I can't find a straightforward replacement after quickly searching around. I myself also never used the rackspace cloud so I have no idea. I currently put a python2 marker in the setup.py so that python-cloudfiles will only be installed in python2, which means the rackspace backend will fail under python3.

  2. I have to relax the version requirement for gitpython, since the old gitpython was also not compatible to python2. It seems the most recent gitpython==2.1.11 works fine.

Please let me know what you think. Thanks!

@MQQ
Copy link
Collaborator

MQQ commented Feb 1, 2019

@dlo Sorry for pushing this. But it would be great if this can be resolved earlier, which will really help my current project workflow. Thanks!

@dlo
Copy link
Member Author

dlo commented Feb 1, 2019

Hi @MQQ! Thanks again for contributing! I just had a few comments on the PR for you to take a look at. Otherwise everything looks great.

#43

@MQQ
Copy link
Collaborator

MQQ commented Feb 1, 2019

ah, I added a review comment a couple of days ago but I forgot to actually click the submit button. My bad :p

@dlo
Copy link
Member Author

dlo commented Feb 2, 2019

Just pushed up to PyPi. Thanks so much again!

@MQQ
Copy link
Collaborator

MQQ commented Feb 3, 2019

Great! Very happy to help!

@dlo dlo removed the help wanted label Feb 9, 2019
@dlo dlo assigned MQQ Feb 9, 2019
@dlo dlo closed this as completed Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants