-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data integrity tests #15
Conversation
I curated all of the remaining issues in Bioportal away in e29c159 |
I have a feeling there might be some logic issues with the merge, so better not to worry about this on first round of this PR
Great tests! I want to see if I can get that |
I think this is probably sufficient for now, though I'll likely have further updates to the BP maps quite soon. |
@caufieldjh thanks for making the BioPortal updates and getting this up to date! It's now merged with master and done from my side. |
As a step towards addressing #11, this PR adds four data integrity tests:
namespace_alias
record has a corresponding prefix in acanonical
recordprefix
record has a corresponding namespace in acanonical
recordMost of these tests are failing, so having a second set of eyes on them (@caufieldjh ;)) will be great. We can start updating the content further until these tests pass, either in this PR or in a different one. However, it might also point out some more systematic issues in the ETL pipelines, so I would also suggest @hrshdhgd takes a careful look too.
Blockers