Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible unnecessary error checking loading from included contexts #75

Open
ptgolden opened this issue Sep 23, 2024 · 1 comment
Open

Comments

@ptgolden
Copy link

While investigating monarch-initiative/monarch-app#819, I noticed a bottleneck in loading the "merged" context in these lines in curie:

https://github.com/biopragmatics/curies/blob/47d1f22e3aba42ea365cd7e99403eacfede4af5a/src/curies/api.py#L527-L533

Is it necessary to check for duplicate prefixes on known-good prefix maps (i.e. those bundled with this package)? If not, the converter loaded here:

if isinstance(names, str):
return load_context(names, refresh=refresh).as_converter()

can be initialized with strict=False, resulting in a speedup of about ~15s on the "merged" context. I am happy to create a PR if that sounds okay.

@ptgolden
Copy link
Author

ptgolden commented Sep 23, 2024

To be clear, strict=False would be added as a keyword to the .from_extended_prefix_map method here:

def as_converter(self) -> curies.Converter:
"""
Get a converter from this prefix map.
:return:
"""
extended_prefix_map = self.as_extended_prefix_map()
return curies.Converter.from_extended_prefix_map(extended_prefix_map)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant