We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
While investigating monarch-initiative/monarch-app#819, I noticed a bottleneck in loading the "merged" context in these lines in curie:
https://github.com/biopragmatics/curies/blob/47d1f22e3aba42ea365cd7e99403eacfede4af5a/src/curies/api.py#L527-L533
Is it necessary to check for duplicate prefixes on known-good prefix maps (i.e. those bundled with this package)? If not, the converter loaded here:
prefixmaps/src/prefixmaps/io/parser.py
Lines 30 to 31 in c61e812
can be initialized with strict=False, resulting in a speedup of about ~15s on the "merged" context. I am happy to create a PR if that sounds okay.
strict=False
The text was updated successfully, but these errors were encountered:
To be clear, strict=False would be added as a keyword to the .from_extended_prefix_map method here:
.from_extended_prefix_map
prefixmaps/src/prefixmaps/datamodel/context.py
Lines 379 to 386 in c61e812
Sorry, something went wrong.
No branches or pull requests
While investigating monarch-initiative/monarch-app#819, I noticed a bottleneck in loading the "merged" context in these lines in curie:
https://github.com/biopragmatics/curies/blob/47d1f22e3aba42ea365cd7e99403eacfede4af5a/src/curies/api.py#L527-L533
Is it necessary to check for duplicate prefixes on known-good prefix maps (i.e. those bundled with this package)? If not, the converter loaded here:
prefixmaps/src/prefixmaps/io/parser.py
Lines 30 to 31 in c61e812
can be initialized with
strict=False
, resulting in a speedup of about ~15s on the "merged" context. I am happy to create a PR if that sounds okay.The text was updated successfully, but these errors were encountered: