Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential bug in the merge algorithm #50

Open
cthoyt opened this issue Oct 20, 2023 · 0 comments
Open

Potential bug in the merge algorithm #50

cthoyt opened this issue Oct 20, 2023 · 0 comments

Comments

@cthoyt
Copy link
Collaborator

cthoyt commented Oct 20, 2023

In #48, I incorporated prefix synonyms from the Bioregistry. Since it links all of the many Wikidata CURIE prefix variants together (wd, wikidata, WD_Entity), it's surprising that there are still disconnected prefix expansions:

merged,wd,http://www.wikidata.org/entity/,canonical,prefixcc

merged,WIKIDATA,http://identifiers.org/wikidata/,canonical,bioregistry

I think this is a problem because of how the merging algorithm works. The issue might be that merge algorithm doesn't have a way to stitch two previously disjoint canonical CURIE/URI prefix records together when it's given synonyms (or it is doing it, but not getting the optimal results).

Maybe an alternative is to just fix #49 directly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant