Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uri slot value for date type #146

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix uri slot value for date type #146

wants to merge 2 commits into from

Conversation

vincentvialard
Copy link
Contributor

bring uri value in sync with notes, just like time a few lines above

@cmungall cmungall requested a review from hsolbrig January 26, 2023 18:56
cmungall
cmungall requested changes Jan 26, 2023
View reviewed changes
Copy link
Member

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as request changes until we can do a thorough review, this will have implications as these types are used for mapping

@cmungall cmungall mentioned this pull request Jan 30, 2024
Open
@cmungall
Copy link
Member

Potentially try for 1.7, may need to wait til 1.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmungall cmungall cmungall requested changes

@hsolbrig hsolbrig Awaiting requested review from hsolbrig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincentvialard @cmungall