Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implicit axis order? #8

Open
sneakers-the-rat opened this issue Feb 3, 2024 · 3 comments
Open

implicit axis order? #8

sneakers-the-rat opened this issue Feb 3, 2024 · 3 comments

Comments

@sneakers-the-rat
Copy link

Small question - I like the ability to explicitly declare axis order with axis_index!!! is it also the case that the order of the axis declaration is meaningful in the absence of an explicit axis_index?

@rly
Copy link
Collaborator

rly commented Feb 3, 2024

I'm not sure. I would assume that the list of slots and dictionary of attributes in a class definition are ordered and we can take advantage of that, but I would want @cmungall or someone else from linkml to confirm...

@cmungall
Copy link
Member

cmungall commented Feb 3, 2024

Ordering is preserved, but it's good to be explicit. The ordering could be lost for example in serializing a schema to OWL

@sneakers-the-rat
Copy link
Author

That's fair. Maybe outside the scope of this issue, but is there some kind of schema for different generators? I am only really familiar with the pydantic generator & i think a decent amount of schemaview, but if not it might be nice to start doing that so that we can keep track of which target formats need to have array order explicitly encoded vs those that encode it naturally so we could do ergonomic things like allow axis to be implicit in the source definition, but then know to automatically generate explicit indices when generating OWL. low priority tho. feel free to close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants