Implemented ReadDoubleVector instead of ReadDoubleArray for crate::CrateDataTypeId::CRATE_DATA_TYPE_DOUBLE_VECTOR #197
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses the management of the DoubleVector type in crates:
the original approach was to use ReadDoubleArray for crate::CrateDataTypeId::CRATE_DATA_TYPE_DOUBLE_VECTOR but the OpenUSD implementation has a dedicated codepath for it (that does not account for compression or 32bit sizes of older formats)
https://github.com/PixarAnimationStudios/OpenUSD/blob/release/pxr/usd/usd/crateFile.cpp#L1069
This patch adds a ReadDoubleVector that does the same thing as the code above.
In addition to this the patch adds a check for zero-sized array in ReadDoubleArray
This patch allows to load the spinning top asset from OpenUSD and flatten it with all of the TimeSamples (https://github.com/PixarAnimationStudios/OpenUSD/blob/release/extras/usd/tutorials/animatedTop/top.geom.usd)
Note that the top.geom.usd asset has TimeSampled indices, that will be supported in a different pull request i am going to send in few minutes