[External project "assimp"] Loading of some models broken due to early return introduced at commit 30481ec

[tellypresence]

Fixed by #177

(This regards tinyusdz integration in external project assimp)

Bisected and found the 2 adjacent commits where it was working (616302d), then broke (30481ec)

2 models downloaded from Sketchfab were working up through commit 616302d back in April, then broke at the next commit 30481ec.

The cause was an early return introduced in file src/tydra/render-data.cc at commit 30481ec

Replacing the early return

  if (skelPath.is_valid()) {
    if (!ConvertSkeletonImpl(env, abs_path.full_path_name(), mesh, &skel)) {
      return false; // <<< this will never continue additional crucial model processing
    }
    // Do skeleton stuff
  }
  // Do additional crucial model processing

with opposite logic so skeleton processing done if check succeeds

  if (skelPath.is_valid()) {
    if (ConvertSkeletonImpl(env, abs_path.full_path_name(), mesh, &skel)) {
        // Do skeleton stuff
    }
  }
  // Do additional crucial model processing

fixes the problem; the breakage was due to other crucial steps needing to be done in the same function after the skeleton processing -- this change makes skeleton steps optional instead of aborting the model processing if skeleton check fails.

Commit	Model	Screenshot	Notes
30481ec 20 Apr 2024 Broken	Medical Assistance Bot	N/A
	ガンダムEX/Gundam EX	N/A
616302d 20 Apr 2024 Working	Medical Assistance Bot
	ガンダムEX/Gundam EX

[tellypresence]

Source of problem has been determined via bisect and iteration

[syoyo]

You should not post a discussion about external project.