Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix call to Intersect() in TestLeafNodeIntersections() #50

Open
Tyler799 opened this issue Oct 24, 2019 · 1 comment
Open

Fix call to Intersect() in TestLeafNodeIntersections() #50

Tyler799 opened this issue Oct 24, 2019 · 1 comment

Comments

@Tyler799
Copy link
Contributor

The call here is different (I suspect old) in which the first two parameters are a min_t and max_t instead of local_t, so the call is invalid. Not sure what else needs to change.

If TestLeafNodeIntersections() itself is deprecated it should be removed or replaced.

@syoyo
Copy link
Contributor

syoyo commented Oct 25, 2019

TestLeafNodeIntersections is used in NanoSG example(for two-level BVH traverse) and NanoSG supplies custom Intersector class for it https://github.com/lighttransport/nanort/blob/master/examples/nanosg/nanosg.h#L571

We may better to assign different class(template) name for TestLeafNodeIntersections to distinguish Intersector used in Traverse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants