Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA_REST problem EXPERIMENTAL_PROXY_URL #160

Open
fssrepository opened this issue Feb 24, 2020 · 1 comment
Open

KAFKA_REST problem EXPERIMENTAL_PROXY_URL #160

fssrepository opened this issue Feb 24, 2020 · 1 comment

Comments

@fssrepository
Copy link

fssrepository commented Feb 24, 2020 •
edited
Loading

I'm using nginx and had put kafka-topics-ui under subPath.

I'm not sure what you are using, but it could be far easier to introduce $KAFKA_REST in the run.sh instead of $EXPERIMENTAL_PROXY_URL pls. Now I'm overriding your whole run.sh!

It's a bad coding practice to use the same $KAFKA_REST_PROXY_URL first with a configured value and override in the script later on.
@fssrepository fssrepository changed the title KAFKA_REST problem KAFKA_REST problem EXPERIMENTAL_PROXY_URL Feb 24, 2020
@fssrepository fssrepository mentioned this issue Feb 24, 2020
Open
@mariosant
Copy link
Contributor

Hey @fssrepository, thanks for the suggestion. I am not entirely sure of what you are suggesting there. Would you like to submit a PR for further iteration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mariosant @fssrepository