-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bind for peek-legit-discard-file conflicts with vi-mode #1513
Comments
I've encountered quite a few modes where vi-mode feels like a second class citizen.
Who knows what else. They make you go into vi insert-mode to do anything. |
yeah… those issues are not fun. My "fix" would be to ensure we enter Legit in Emacs mode or vi insert mode, so we don't have the conflicts. |
There has to be a better way. If Emacs can do it, why not Lem? I'm going to keep thinking about it. |
I don't fully agree. For VI users normal mode/motion mode is the standard so that should be honored even in 3rd party packages. For "discard" I'd suggest "x" as that would work with vi-mode in normal just fine! Magit also uses that I believe |
Take a look at #1515. I didn't do anything for legit yet, but I could. I just chose to fix some of the simpler modes first as a proof of concept. |
Because of this keybind you can't navigate in normal mode in legit which makes it kind of unusable.
(define-key *peek-legit-keymap* "k" 'peek-legit-discard-file)
The text was updated successfully, but these errors were encountered: