made padding consistent by adding h3 class to ProgramGrid component and using that instead of passing a subtitle prop for the subtitle #6087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: faatima_abidi <[email protected]>
|
🚀 Preview for commit a199d8c at: https://673e79cfa111e9a3ab9a2501--layer5.netlify.app |
|
@FaatimaAbidi adding it as an agenda item to the meeting minutes. |
sudhanshutech
requested changes
Nov 29, 2024
| @@ -57,7 +57,8 @@ const ProgramsGrid = ({ hide_path, sub_section }) => { | |||
|
|
|||
| return ( | |||
| <ProgramsPageWrapper> | |||
| <PageHeader title="Open Source Internship Programs" subtitle="Build Your Career at Layer5" path={path} /> | |||
There was a problem hiding this comment.
is this pageheader used elsewhere also, i guess yes. So why only here the subtitle having the css issues and not elsewhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #5648
Notes for Reviewers
Signed commits