Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added List component to the sistent components page #6086

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

csengineer1990
Copy link
Contributor

Description

This PR fixes #5951
By adding the List component to the Sistent Components page.
The required content and documentation for the List component have been included, along with updates to the necessary files.

Notes for Reviewers
I have made the following changes:
Added the List of component implementation and documentation.
Updated the related files to reflect these changes.
Could you review the updates and let me know if any additional changes or content updates are required?

Signed commits

  • Yes, I signed my commits.

@github-actions github-actions bot added area/projects An issue relating to Layer5 initiatives (projects) project/sistent labels Nov 20, 2024
@l5io
Copy link
Contributor

l5io commented Nov 20, 2024

🚀 Preview for commit 9f5a6b7 at: https://673daeac4ab01b5bf2a3bc3c--layer5.netlify.app

@mdkaifansari04
Copy link
Contributor

image

You can consider adding all Types of List component into that navigation-menu

@csengineer1990
Copy link
Contributor Author

image

You can consider adding all Types of List components into that navigation-menu

@mdkaifansari04
Thank you for the feedback!

I’m not entirely sure where you’d like me to make the suggested changes regarding adding all types of List components to the navigation menu. Could you please provide more clarification?
Additionally, I noticed that the attached image isn’t visible on my end. If possible, could you reattach it or provide additional details? That would help me make the necessary updates more effectively.

Thank you!

@mdkaifansari04
Copy link
Contributor

image
If you look up to this side navigation menu, it has one menu as List Component. Try adding more menu items that is been presented in the overview section

@sudhanshutech
Copy link
Member

change the structure of page as per new changes made around adding sistent components

@csengineer1990
Copy link
Contributor Author

image If you look up to this side navigation menu, it has one menu as List Component. Try adding more menu items that is been presented in the overview section

Please check I have made the changes.

@l5io
Copy link
Contributor

l5io commented Nov 22, 2024

🚀 Preview for commit 3ab022b at: https://674009ea0d52eefebdee81a6--layer5.netlify.app

@csengineer1990
Copy link
Contributor Author

change the structure of page as per new changes made around adding sistent components

Could you please elaborate on what you mean by changing the structure of the page with the new Sistent components? I’d appreciate it if you could guide me on where exactly the changes need to be made or what specific updates are required. This will help me ensure that I address your requirements accurately. Thank you!

@sudhanshutech
Copy link
Member

change the structure of page as per new changes made around adding sistent components

Could you please elaborate on what you mean by changing the structure of the page with the new Sistent components? I’d appreciate it if you could guide me on where exactly the changes need to be made or what specific updates are required. This will help me ensure that I address your requirements accurately. Thank you!

you don't have to create dir under pages , it will automatically created.

@vishalvivekm
Copy link
Member

@csengineer1990
Thank you for your contribution!
Let's discuss this during the website call on Monday at 6:30 PM IST

adding it as an agenda item to the meeting minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/projects An issue relating to Layer5 initiatives (projects) project/sistent
Development

Successfully merging this pull request may close these issues.

[Sistent] Add List component to the sistent components page
5 participants