Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: model params in logs #11298

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Fix: model params in logs #11298

merged 1 commit into from
Dec 3, 2024

Conversation

JzoNgKVO
Copy link
Contributor

@JzoNgKVO JzoNgKVO commented Dec 3, 2024

Summary

Fix wrong reference of model completion params in logs #11026

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 3, 2024
@JzoNgKVO JzoNgKVO requested a review from crazywoola December 3, 2024 09:17
@dosubot dosubot bot added the 🐞 bug Something isn't working label Dec 3, 2024
@laipz8200 laipz8200 mentioned this pull request Dec 3, 2024
5 tasks
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 3, 2024
@crazywoola crazywoola merged commit ff2a4a6 into main Dec 3, 2024
7 checks passed
@crazywoola crazywoola deleted the fix/model-params-in-logs branch December 3, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants