Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roll back rerank topn setting #11297

Merged
merged 3 commits into from
Dec 3, 2024
Merged

roll back rerank topn setting #11297

merged 3 commits into from
Dec 3, 2024

Conversation

JohnJyong
Copy link
Contributor

Summary

roll back rerank topn setting

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before: After:
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@JohnJyong JohnJyong requested a review from takatost December 3, 2024 09:14
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 3, 2024
laipz8200
laipz8200 previously approved these changes Dec 3, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 3, 2024
@laipz8200 laipz8200 merged commit c58d2fc into main Dec 3, 2024
10 checks passed
@laipz8200 laipz8200 deleted the fix/roll-back-rerank-top-n branch December 3, 2024 09:34
@crazywoola crazywoola mentioned this pull request Dec 3, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants