Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying framework: drupal10 leads to error #242

Closed
karldivad opened this issue Apr 25, 2024 · 1 comment
Closed

Specifying framework: drupal10 leads to error #242

karldivad opened this issue Apr 25, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@karldivad
Copy link
Contributor

When updating .lando.yml file to drupal10 it breaks nginx container with the following error:

sed: read error on /tmp/vhosts.conf.lando: Is a directory

Example lando file:

name: example-project
recipe: pantheon
config:
  framework: drupal10
  site: example-project
  id: 123456789-qwertyuiop
@karldivad karldivad added the bug Something isn't working label Apr 25, 2024
@reynoldsalec reynoldsalec changed the title Drupal 10 recipe is needed Specifying framework: drupal10 leads to error Apr 30, 2024
@reynoldsalec
Copy link
Member

@karldivad I think the reason this hasn't been an issue is that when Lando assigns a framework value, it uses a value provided by Pantheon that uses a different value (say drupal8 for sites up to Drupal 10)...made a follow-up issue to make sure the recipe is really handling this well: #245

For the time being, definitely agree that to prevent user confusion allowing a drupal10 framework value is good and that your PR should resolve that issue...totally see how it's confusing. Thanks for the contribution @karldivad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants