Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pantheon appservers don't have PHP tidy extension #11

Open
dustinleblanc opened this issue Jul 28, 2020 · 5 comments
Open

Pantheon appservers don't have PHP tidy extension #11

dustinleblanc opened this issue Jul 28, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@dustinleblanc
Copy link

Pantheon's appservers have the html tidy extension and Lando/Localdev does not, we should add this extension to the containers. See https://pantheon-community.slack.com/archives/CB2H8065D/p1595455998128500?thread_ts=1595449559.127700&cid=CB2H8065D

@dustinleblanc dustinleblanc self-assigned this Jul 28, 2020
@pirog
Copy link
Member

pirog commented Jul 28, 2020

@dustinleblanc do we not want to support this via lando/lando#2371?

@dustinleblanc
Copy link
Author

Ideally yes, I pinged Pantheon this morning as this reminded me of the outstanding issue.

@stale
Copy link

stale bot commented Apr 27, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions and please check out this if you are wondering why we auto close issues.

@rtfm-47 rtfm-47 transferred this issue from lando/lando Nov 24, 2021
@reynoldsalec reynoldsalec added enhancement New feature or request and removed Needs Triage labels Feb 23, 2022
@reynoldsalec
Copy link
Member

...this came up in a recent Slack convo. The proposal in #10 had been to move towards using "actual" Pantheon images for Lando, but I believe that hasn't been considered as an option for some time. I think we could build this into the Pantheon recipe another way...will have to look at this.

In the meantime, if you need tidy, an implementation using the build_as_root option for your site's appserver service should work. Add this to your .lando.yml file:

services:
  appserver:
    build_as_root:
      - apt-get update && apt-get install -y libtidy-dev && docker-php-ext-install tidy && docker-php-ext-enable tidy

I'm not 100% sure about libtidy versions/compatibility with PHP versions, so you may need to install a different package, but something like that should work!

@gitressa
Copy link

Thanks for sharing that solution @reynoldsalec! That works perfectly, and Tidy is installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants