Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 8.4 #119

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Add support for PHP 8.4 #119

merged 1 commit into from
Oct 29, 2024

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Oct 10, 2024

No description provided.

@gsteel gsteel added this to the 3.20.0 milestone Oct 10, 2024
@gsteel gsteel changed the title Add support for PHP 8.4, Add Roave BC Check to CI Add support for PHP 8.4 Oct 10, 2024
@gsteel
Copy link
Member Author

gsteel commented Oct 10, 2024

Seems to be a problem in BetterReflection causing BC checker to fail. Skipping for now

@k00ni
Copy link

k00ni commented Oct 24, 2024

Is there a way to help you finish PHP 8.4 support? Is there an agenda or list of TODOs left to solve?

My fork of EasyRdf is using this library and on PHP 8.4 a few tests throw deprecations such as:

[...]
8) /var/www/html/vendor/laminas/laminas-stdlib/src/DispatchableInterface.php:20
Laminas\Stdlib\DispatchableInterface::dispatch(): Implicitly marking parameter $response as nullable 
is deprecated, the explicit nullable type must be used instead

@gsteel
Copy link
Member Author

gsteel commented Oct 24, 2024

Is there a way to help you finish PHP 8.4 support? Is there an agenda or list of TODOs left to solve?

My fork of EasyRdf is using this library and on PHP 8.4 a few tests throw deprecations such as:

[...]
8) /var/www/html/vendor/laminas/laminas-stdlib/src/DispatchableInterface.php:20
Laminas\Stdlib\DispatchableInterface::dispatch(): Implicitly marking parameter $response as nullable 
is deprecated, the explicit nullable type must be used instead

@k00ni

That was fixed back in 2021: 87bc3d1#diff-9a2656b608d79a369e0808345bfd465e10bf9a2e5fc31a2a3ca93bfe310b4e2fR14

Maybe you need to bump your minimum deps.

This lib is already 8.4 compatible as of ^3.19 - this patch just updates composer with "official" support

@gsteel gsteel requested a review from a team October 24, 2024 13:02
Signed-off-by: George Steel <[email protected]>
@gsteel gsteel removed the request for review from a team October 29, 2024 13:38
@gsteel gsteel self-assigned this Oct 29, 2024
@gsteel gsteel merged commit 803ec65 into laminas:3.20.x Oct 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants